push texture to vshader sha file

thien0291 · March 8, 2013, 8:10am

I am coding Water Effect with Perlin Noise algorithm. It need to change height of geomipmap by time. This algorithm use a image to set height of geomipmap. i try to put texture to vshader (in sha file) but it return a errors :

//Cg
//Cg profile arbvp1 arbfp1

// shader loosely based on pro-rsoft’s from the panda3d forums
// shader assumes 6 texture stages:
// 0-2 textures
// 3-5 alpha maps
// vertex shader accepts unit 0 and 3 texture coords as input
// and outputs unit 0 scaled and unit 3 unchanged
// fragment shader uses unit 0 coordinates to access textures
// and unit 3 coordinates (un-scaled) to access alpha maps
// gsk, june-2008

void vshader( in float4 vtx_position : POSITION,
in float3 vtx_normal : NORMAL,
in float2 vtx_texcoord0 : TEXCOORD0,
in float2 vtx_texcoord3 : TEXCOORD3,
in uniform float4x4 mat_modelproj,
in uniform float4x4 trans_model_to_world,
in uniform sampler2D k_PerNoise11 : TEXUNIT0,
in uniform float4 k_lightvec,
in uniform float4 k_lightcolor,
in uniform float4 k_ambientlight,
in uniform float4 k_tscale,
in uniform float3 k_CamPos,
in uniform float k_zscale,
//in uniform float2 PerNoise[65536],
out float4 l_brightness,
out float4 l_lightcolor,
out float4 l_mpos,
out float2 l_texcoord0 : TEXCOORD0,
out float2 l_texcoord3 : TEXCOORD3,
out float4 l_position : POSITION)
{

// worldspace position, for clipping in the fragment shader
l_mpos = mul(trans_model_to_world, vtx_position);

l_position=mul(mat_modelproj,vtx_position);
l_texcoord0=vtx_texcoord0*k_tscale;

float4 tex1=tex2D(k_PerNoise11,l_texcoord0);
l_texcoord3=vtx_texcoord3;
vtx_normal.z /= k_zscale;

// lighting
float3 N = normalize( vtx_normal );
float3 L = normalize( k_lightvec.xyz );
l_brightness = (max( dot( -N, L ), 0.0f )*k_lightcolor)+k_ambientlight;

}

void fshader( in float4 l_position : POSITION,
in float2 l_texcoord0 : TEXCOORD0,
in float2 l_texcoord3 : TEXCOORD3,
in float4 l_brightness,
in float4 l_lightcolor,
in float4 l_mpos,
in uniform float4 k_waterlevel,
in uniform sampler2D tex_0 : TEXUNIT0,
in uniform sampler2D tex_1 : TEXUNIT1,
in uniform sampler2D tex_2 : TEXUNIT2,
in uniform sampler2D tex_3 : TEXUNIT3,
in uniform sampler2D tex_4 : TEXUNIT4,
in uniform sampler2D tex_5 : TEXUNIT5,
out float4 o_color : COLOR )
{
// clipping
if ( l_mpos.z < k_waterlevel.z) discard;

// alpha splatting and lighting
float4 tex1=tex2D(tex_0,l_texcoord0);
float4 tex2=tex2D(tex_1,l_texcoord0);
float4 tex3=tex2D(tex_2,l_texcoord0);
float alpha1=tex2D(tex_3,l_texcoord3).z;
float alpha2=tex2D(tex_4,l_texcoord3).z;
float alpha3=tex2D(tex_5,l_texcoord3).z;
o_color =tex1alpha1;
o_color+=tex2alpha2;
o_color+=tex3*alpha3;
//o_color = 0.5;
//o_color
o_color=o_color(l_brightness);
//o_color=l_lightcolor;
o_color.a=1.0;
}

I try to set

But nothing change.

I try to put all value to Array and use setShaderInput but it say

This is Array Code :

And this is shader file

//Cg
//Cg profile arbvp1 arbfp1

// shader loosely based on pro-rsoft’s from the panda3d forums
// shader assumes 6 texture stages:
// 0-2 textures
// 3-5 alpha maps
// vertex shader accepts unit 0 and 3 texture coords as input
// and outputs unit 0 scaled and unit 3 unchanged
// fragment shader uses unit 0 coordinates to access textures
// and unit 3 coordinates (un-scaled) to access alpha maps
// gsk, june-2008

void vshader( in float4 vtx_position : POSITION,
in float3 vtx_normal : NORMAL,
in float2 vtx_texcoord0 : TEXCOORD0,
in float2 vtx_texcoord3 : TEXCOORD3,
in uniform float4x4 mat_modelproj,
in uniform float4x4 trans_model_to_world,
in uniform float4 k_lightvec,
in uniform float4 k_lightcolor,
in uniform float4 k_ambientlight,
in uniform float4 k_tscale,
in uniform float3 k_CamPos,
in uniform float k_zscale,
in uniform float PerNoise[65536],
out float4 l_brightness,
out float4 l_lightcolor,
out float4 l_mpos,
out float2 l_texcoord0 : TEXCOORD0,
out float2 l_texcoord3 : TEXCOORD3,
out float4 l_position : POSITION)
{

// worldspace position, for clipping in the fragment shader
l_mpos = mul(trans_model_to_world, vtx_position);

// float4 tex1=tex2D(tex_0,l_texcoord0);

l_position=mul(mat_modelproj,vtx_position);
l_texcoord0=vtx_texcoord0*k_tscale;
l_texcoord3=vtx_texcoord3;
vtx_normal.z /= k_zscale;

// lighting
float3 N = normalize( vtx_normal );
float3 L = normalize( k_lightvec.xyz );
l_brightness = (max( dot( -N, L ), 0.0f )*k_lightcolor)+k_ambientlight;

}

void fshader( in float4 l_position : POSITION,
in float2 l_texcoord0 : TEXCOORD0,
in float2 l_texcoord3 : TEXCOORD3,
in float4 l_brightness,
in float4 l_lightcolor,
in float4 l_mpos,
in uniform float4 k_waterlevel,
in uniform sampler2D tex_0 : TEXUNIT0,
in uniform sampler2D tex_1 : TEXUNIT1,
in uniform sampler2D tex_2 : TEXUNIT2,
in uniform sampler2D tex_3 : TEXUNIT3,
in uniform sampler2D tex_4 : TEXUNIT4,
in uniform sampler2D tex_5 : TEXUNIT5,
out float4 o_color : COLOR )
{
// clipping
if ( l_mpos.z < k_waterlevel.z) discard;

// alpha splatting and lighting
float4 tex1=tex2D(tex_0,l_texcoord0);
float4 tex2=tex2D(tex_1,l_texcoord0);
float4 tex3=tex2D(tex_2,l_texcoord0);
float alpha1=tex2D(tex_3,l_texcoord3).z;
float alpha2=tex2D(tex_4,l_texcoord3).z;
float alpha3=tex2D(tex_5,l_texcoord3).z;
o_color =tex1alpha1;
o_color+=tex2alpha2;
o_color+=tex3*alpha3;
//o_color = 0.5;
//o_color
o_color=o_color(l_brightness);
//o_color=l_lightcolor;
o_color.a=1.0;
}

Please help me what i have to do that ?!

================
Upadate:

My Project too big to upload here (over 150 classes) so i can’t upload all project. But I use original source and a little edit.

mediafire.com/?zp2uwimirb1f1ui

Yarr.py
shaders/splut3Normal.sha

rdb · March 8, 2013, 8:33am

Passing a texture to a shader requires Vertex Texture Fetch, which not all cards support. All of my NVIDIA cards have no problem with it. Which card do you have?

thien0291 · March 8, 2013, 8:51am

I run it on my laptop
Graphic card is AMD Radeon 5470M…

====
have another way to generate it ?!
I think it like a geomipmap with heighmap file change by time. And all GPU support geomipmap

ninth · March 8, 2013, 1:46pm

I can be wrong, but as I see, you pass the array to the shader, not a Texture.
May be do something like
tex = Texture()
tex.load(myPNMImg)
root.setShaderInput(‘PerNoise’, tex)

Also try to remove some uniform inputs or temporary replace it with hardcoded constants. Before, I had some problems with it on ATI card.

rdb · March 8, 2013, 9:30pm

Well, the bug with adding an float array is a different one, and it’s probably a bug in Panda3D. Does it work if you use a float4 array instead of a float array?

thien0291 · March 9, 2013, 1:46am

I change in shader file from float to float4… But nothing change

thien0291 · March 9, 2013, 1:59am

I try by your way. But like a result in top of topic. It’s Say

ninth · March 9, 2013, 7:07am

Is original example works as expected? Give me link on this example, plz.

thien0291 · March 10, 2013, 3:43am

My Project too big to upload here (over 150 classes) so i can’t upload all project. But I use original source and a little edit.

mediafire.com/?zp2uwimirb1f1ui

Yarr.py
shaders/splut3Normal.sha

I hope you can help

rdb · March 10, 2013, 9:19am

In any case, you should get rid of the “//Cg profile arbvp1 arbfp1” on top of your file. That’s telling your shader to use the weakest profile available, overriding your setting of basic-shaders-only.

ninth · March 10, 2013, 10:14am

Well, seems that Cg actually is very outdated or strongly dislikes ATI :). My videocard supports 16 texture units in the vertex shader, but Cg tell me that “Cg program too complex for driver”. I rewrote shader in GLSL and it’s works as expected for me.
Here my equivalent GLSL vertex and fragmet shaders:

uniform vec4 lightvec;
uniform vec4 lightcolor;
uniform vec4 ambientlight;
uniform sampler2D p3d_Texture0;

varying vec4 brightness;

void main()
{
    float test = texture2D(p3d_Texture0, vec2(gl_MultiTexCoord0)).x;
    vec4 co = gl_Vertex;
    co.z += test; // displace
    gl_Position = gl_ModelViewProjectionMatrix * co;
    gl_TexCoord[0] = gl_MultiTexCoord0;

    vec3 N = normalize( gl_NormalMatrix * gl_Normal );
    vec3 L = normalize(lightvec.xyz);
    
    brightness = max( dot( -N, L ), 0.0f ) * lightcolor + ambientlight;
}

uniform sampler2D p3d_Texture0;
uniform sampler2D p3d_Texture1;
uniform sampler2D p3d_Texture2;
uniform sampler2D p3d_Texture3;
uniform sampler2D p3d_Texture4;
uniform sampler2D p3d_Texture5;

varying vec4 brightness;

void main(void)
{
    vec4 tex0 = texture2D(p3d_Texture0, vec2(gl_TexCoord[0]));
    vec4 tex1 = texture2D(p3d_Texture1, vec2(gl_TexCoord[0]));
    vec4 tex2 = texture2D(p3d_Texture2, vec2(gl_TexCoord[0]));
    float alpha0 = texture2D(p3d_Texture3, vec2(gl_TexCoord[0])).z;
    float alpha1 = texture2D(p3d_Texture4, vec2(gl_TexCoord[0])).z;
    float alpha2 = texture2D(p3d_Texture5, vec2(gl_TexCoord[0])).z;
    gl_FragColor = tex0 * alpha0 + tex1 * alpha1 + tex2 * alpha2;
    gl_FragColor *= brightness;
}

and result:

rdb · March 10, 2013, 10:50am

It’s not Cg itself that’s the problem, it’s how the shader is compiled. He forced it into arbfp1 arbvp1 mode, which doesn’t have much functionality at all.

Cg can be compiled to GLSL using the glslf and glslv profiles (in fact, I think that’s what’s supposed to happen if you don’t request an explicit profile and set basic-shaders-only to false) anyway.

ninth · March 10, 2013, 11:17am

Hmm. Yes, indeed I found “//Cg profile arbfp1 arbvp1” entry at top of the original shader. I’ve tryed to replace it with “//Cg profile glslf glslv” and tryed fully remove this entry, and of course, I used “basic-shaders-only #f”, but nothing changes, Cg still reports that program too complex.

thien0291 · March 10, 2013, 4:24pm

I have same result like [color=red]ninth

thien0291 · March 11, 2013, 8:26am

ninth:

Well, seems that Cg actually is very outdated or strongly dislikes ATI . My videocard supports 16 texture units in the vertex shader, but Cg tell me that “Cg program too complex for driver”. I rewrote shader in GLSL and it’s works as expected for me.
Here my equivalent GLSL vertex and fragmet shaders:

uniform vec4 lightvec;
uniform vec4 lightcolor;
uniform vec4 ambientlight;
uniform sampler2D p3d_Texture0;

varying vec4 brightness;

void main()
{
    float test = texture2D(p3d_Texture0, vec2(gl_MultiTexCoord0)).x;
    vec4 co = gl_Vertex;
    co.z += test; // displace
    gl_Position = gl_ModelViewProjectionMatrix * co;
    gl_TexCoord[0] = gl_MultiTexCoord0;

    vec3 N = normalize( gl_NormalMatrix * gl_Normal );
    vec3 L = normalize(lightvec.xyz);
    
    brightness = max( dot( -N, L ), 0.0f ) * lightcolor + ambientlight;
}

uniform sampler2D p3d_Texture0;
uniform sampler2D p3d_Texture1;
uniform sampler2D p3d_Texture2;
uniform sampler2D p3d_Texture3;
uniform sampler2D p3d_Texture4;
uniform sampler2D p3d_Texture5;

varying vec4 brightness;

void main(void)
{
    vec4 tex0 = texture2D(p3d_Texture0, vec2(gl_TexCoord[0]));
    vec4 tex1 = texture2D(p3d_Texture1, vec2(gl_TexCoord[0]));
    vec4 tex2 = texture2D(p3d_Texture2, vec2(gl_TexCoord[0]));
    float alpha0 = texture2D(p3d_Texture3, vec2(gl_TexCoord[0])).z;
    float alpha1 = texture2D(p3d_Texture4, vec2(gl_TexCoord[0])).z;
    float alpha2 = texture2D(p3d_Texture5, vec2(gl_TexCoord[0])).z;
    gl_FragColor = tex0 * alpha0 + tex1 * alpha1 + tex2 * alpha2;
    gl_FragColor *= brightness;
}

and result:

Can you upload full package?
I really need it

thien0291 · March 13, 2013, 5:21am

uppppp

ninth · March 13, 2013, 11:14am

I don’t change nothing else shaders code. You can load it like this

shader = Shader.load(Shader.SLGLSL, 'vert.glsl', 'frag.glsl')
model.setShader(shader)

One thing - you need last dev version of Panda, or may be 1.7.2. In 1.8.0 GLSL is broken.

If you relly need full package, I can search it if not deleted.

rdb · March 13, 2013, 3:39pm

For the record, when you get the “too complex” error, you should try “vp40 fp40”.

thien0291 · March 14, 2013, 8:45am

I guess have problem with Cg profile. When I change default profile but when debug profile is no change…

My videocard is and radeon 5470m and with default driver of xubuntu

rdb · February 13, 2014, 12:28pm

Yes, I found out that Cg is simply fundamentally broken on AMD unless you set “basic-shaders-only” and don’t use advanced functionality. Try to use GLSL instead.