Windows : desktop resolution query

Compiling or Editing the Panda Source
1

I added these :

  _display_width = GetSystemMetrics(SM_CXSCREEN);
  _display_height = GetSystemMetrics(SM_CYSCREEN);

to WinGraphicsPipe::Constructor (winGraphicsPipe.cxx).
Is there any known issues about this across OS versions, so it’s not implemented yet ?

2

No, I don’t think so. I think one has just been too lazy to implement it before.
In my python apps, I just use this function through win32api.
I don’t think it would be a problem, unless one changes the screen resolution while Panda3D is running.

I just checked it in, let me know if that is incorrect.

3

That’s cool.
Other unrelated issue :
what’s wrong to display information’s _total_display_modes ? I can’t see it’s populated anywhere, so getTotalDisplayModes() returns 0, both on W&L. It used to work.

4

Odd. Maybe a driver issue.
It always returned 0 for me on linux, but on windows it always worked, I think the last time I checked was at 1.5.2.