As mentioned in here, I’ve made some changes to Transitions, DirectDialog and DirectRadioButton. This thread is intended to get community feedback on those changes.
The altered files, and a small test-program, should be available via this link.
These should be the changes made (presuming that I’ve forgotten nothing, and possibly ignoring some minor changes that can be found via a diff):
-
Transitions
[list]
[]The “fade”-screen is now by default simply a semi-transparent DirectFrame, instead of a model loaded automatically.
[list][]The Panda-provided model can still be used by loading it manually.
[/:m]
[]Changed uses of “setColor” and “lerpColorInterval” to “setColorScale” and “lerpColorScaleInterval”, respectively. -
This means that the changes that Transitions makes only tints fade-models, rather than recolouring them as was previously the case. For one, I found that the use of “setColor” was interfering with the “default model” when that model was loaded manually.
[/:m]
[]A side-effect is that the Panda-provided fade model is now more transparent that it previously was: the model file specifies a degree of transparency (fifty percent, I think it was), which was, I believe, being overwritten by the calls to “setColor”. Using “setColorScale”, both the model’s native transparency and the transparency being specified by the method that shows the fade-screen are being multplied together. However, this is what I would expect to have happen, so I’m inclined to leave it in.[/:m]
[]In “setFadeModel”, added “self.fade.destroy()” before “del self.fade”, as I found that it didn’t seem to be properly cleaned up without the call.[/:m][/list:u][/:m]
[*]DirectDialog -
The backdrop is now by default a basic grey frame if relief is set to “DGG.FLAT” and invisible otherwise, instead of a model loaded automatically.
[list]
[*]The Panda-provided model can still be loaded by setting the dialogue’s “image” constructor keyword to “DGG.getDefaultDialogGeom()”. -
To my mind, while arguably unappealing, the grey frame is at least in keeping with the rest of DirectGUI’s default appearance.
[/:m]
[]Code has been added to catch two places in which calls to “getTightBounds” may return “None”, potentially tripping up the construction of the dialogue.[/:m]
[]The Panda-provided dialogues (“Yes-No”, “Retry-Cancel”, etc.) now by default show with a flat grey frame.[/:m][/list:u][/:m]
[*]DirectRadioButton -
The “boxImage” constructor keyword is now by default “None”, instead of an automatically-loaded model.
-
If no “boxImage” is specified, DirectRadioButton now defaults to a basic sunken frame.
[/*:m][/list:u]
Rdb, you mentioned submitting my changes as a patch in the bug-tracker; presuming that they’re found useful, how do go about doing so? Specifically, how do I create a patch, should I create a “bug report” for this, and is there a way of doing so without signing up for Ubuntu One? (My apologies, I don’t think that I’ve done this before–or at least have forgotten it. ^^; )